feat(api): GET retry children from published tepp-retry-lineage CLI - #403
Conversation
GAP-003A retry-lineage CLI (ADR 0048): operators run tepp-retry-lineage
retries to mint typed naruon/LineageWeave GET /v1/analysis-runs/{run_id}/retries
onto spawned tepp-loopback TCP. Inspect stays metric-free. Persistence
remains GAP-003B. Does not duplicate retry-lineage GET (#379), consumer
parity (#399), retry-parent CLI (#400), or lookup CLI (#401).
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head COMMENT on 2c95104 (draft). Unique occupied: tepp-retry-lineage retries minting GET /v1/analysis-runs/{run_id}/retries (ADR 0048). Stdout is metric-free ("retries": [] when never retried). tepp.scientific_acceptance.v1 never appears. Supports naruon and LineageWeave consumers via typed exchanges. Do not add GET to NaruonLiveService beyond the Naruon-only compatibility inspect already owned by ADR 0045. Do not un-draft. Zero reviews on this SHA before this COMMENT. Never self-approve. Do not weaken fail-closed. No Buyer language. No PII in LineageWeave.
Why
GAP-003A / issue #166 still has no published CLI that GETs
/retriesfrom the typed naruon/LineageWeaveretry-lineage exchange onto spawnedtepp-loopbackTCP. ADR 0035 / #379 owns retry-lineage GET. ADR 0045 / #399 owns consumer-parity exchanges. Operators still had to embed the library or invent HTTP. Retry CLI (#394) and retry-parent CLI (#400) live on diverged stacks that lack retry-lineage GET.Live slices that this PR does not duplicate:
analysis_enginescientific-acceptance library0542042ca05ce1f5976d07ae568c62579a95ece7)What
Unique GAP-003A retry-lineage CLI slice stacked on #399 over protected main
1bc02f580cf48e1d39da239f0e818453437c31c3:tepp-retry-lineage retriesmintsnaruon_analysis_run_retry_lineage_exchangeorlineageweave_analysis_run_retry_lineage_exchangeand renders throughloopback_http1_from_retry_lineage_exchange--originstays the published HTTPS origin; only--hostis the loopback bind address printed bytepp-loopback200 OKinspect ("retries": []when the parent was never retried)localhost, unpublished consumers, credential-shaped flags, metric keys, andhttp://origins fail closedNaruonLiveServicebeyond the Naruon-only compatibility inspect already owned by ADR 0045; LineageWeave remains refused thereNot an ADR 0014 scientific claim. Not retry-lineage GET. Not retry-lineage consumer-parity. Not retry CLI. Not retry-parent CLI. Persistence remains GAP-003B.
Verification
cargo clippy -p tepp_api --all-targets -- -D warningscargo test -p tepp_api --test analysis_run_retry_lineage_cli_contractcargo test -p tepp_api --lib --testscargo doc -p tepp_api --no-depspython3 scripts/validate_documentation.pypython3 scripts/check_docstrings.pyStacking
Base is
feat/analysis-run-retry-lineage-consumer-parity-gap-003a(#399). Merge #399 first or retarget onto main after #399 lands. No force-push.Head:
2c95104774c0e609d856ba8ecbde7f594703273d